Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to Pandas 1.x #1266

Merged
merged 6 commits into from
Aug 11, 2020
Merged

Move to Pandas 1.x #1266

merged 6 commits into from
Aug 11, 2020
+18 −18

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Aug 5, 2020 •
edited
Loading

Description

Pandas reached to 1.0, finally! Changes made were:

  • Replace deprecated ix method for loc (and iloc).
  • Replace deprecated labels attribute fot codes.
  • EmptyDataError exception has been moved to pandas.errors module.

Motivation and Context

We recently updated TARDIS environment to a more recent version of every package.

How Has This Been Tested?

Testing pipeline is ok.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have assigned/requested two reviewers for this pull request.

@epassaro epassaro changed the title Move to Pandas 1.1 Move to Pandas 1.x Aug 5, 2020
@codecov
Copy link

codecov bot commented Aug 5, 2020 •
edited
Loading

Codecov Report

Merging #1266 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1266   +/-   ##
=======================================
  Coverage   80.63%   80.63%           
=======================================
  Files          41       41           
  Lines        3424     3424           
=======================================
  Hits         2761     2761           
  Misses        663      663
Impacted Files Coverage Δ
tardis/io/parsers/csvy.py 89.74% <100.00%> (ø)
tardis/plasma/properties/atomic.py 87.75% <100.00%> (ø)
tardis/plasma/properties/partition_function.py 91.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3e202d...abf4b6c. Read the comment docs.

@epassaro epassaro added the conda label Aug 5, 2020
@kaushik94
Copy link
Contributor

@epassaro I will test this with simulation tests on my machine today.

This was referenced Aug 10, 2020
Closed
Closed
@wkerzendorf
Copy link
Member

Reviewed by me and @chvogl - @kaushik94 can you do your review?

@wkerzendorf wkerzendorf merged commit 0661f6e into tardis-sn:master Aug 11, 2020
@epassaro epassaro mentioned this pull request Aug 12, 2020
Closed
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
@epassaro
Move to Pandas 1.x (tardis-sn#1266)
112c5d7 
* Pin pandas to v1.1

* Replace `codes` with `labels`

* Empty data exception moved to `errors` module

* `ix` method is deprecated

* Pin pandas to v1.0

* [skip-ci] Remove `ix` method from documentation scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaushik94 kaushik94 kaushik94 approved these changes

@wkerzendorf wkerzendorf wkerzendorf approved these changes

Assignees

@wkerzendorf wkerzendorf

@kaushik94 kaushik94

Labels
conda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epassaro @kaushik94 @wkerzendorf